-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 21524 update counselor approved email int #14013
Merged
KonstanceH
merged 16 commits into
integrationTesting
from
B-21524-Update-Counselor-Approved-Email-INT
Oct 30, 2024
Merged
B 21524 update counselor approved email int #14013
KonstanceH
merged 16 commits into
integrationTesting
from
B-21524-Update-Counselor-Approved-Email-INT
Oct 30, 2024
+102
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonstanceH
added
ByteSize M&Ms
Team ByteSized M&Ms
INTEGRATION
Slated for Integration Testing
labels
Oct 25, 2024
taeJungCaci
requested changes
Oct 29, 2024
taeJungCaci
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
WeatherfordAaron
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21524
Summary
This PR updates the counselor approved email to include more information about storage, pro gear and if a move is an actual expense reimbursement.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Test non actual expense move
EMAIL_BACKEND=ses AWS_REGION=us-gov-west-1 aws-vault exec transcom-gov-dev -- make server_run
and then run make client_run
Test actual expense move
Backend
Screenshots
ActualExpenseReimbursement
Not ActualExpenseReimbursement
AC Email:
Email #2 - Your counselor has approved your move details update - 2 Oct 24 (1).docx